Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )
Change subject: util/amdfwtool: Deal with psp position in flash offset directly ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/2966ec8b_a3ba71c0 PS3, Line 15: depending on stack stack usage. Possible repeated word: 'stack'
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/3cacb8e4_5c44842c PS3, Line 2328: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/07153a28_67dce807 PS3, Line 2329: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/1666c5d0_6ccb50fe PS3, Line 2330: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/0a12620b_4c8de40c PS3, Line 2331: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/b7a90d6f_d6d00853 PS3, Line 2332: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164180): https://review.coreboot.org/c/coreboot/+/69852/comment/1bc92671_0457b8e0 PS3, Line 2333: case 0x20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment