Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39860 )
Change subject: soc/intel/tigerlake: Allow mainboard to override DRAM part number
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39860/1/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/39860/1/src/soc/intel/tigerlake/rom...
PS1, Line 101: mainboard_get_dram_part_num(&dram_part_num,
: &dram_part_num_len);
Aah I do remember that now. […]
If we do want to optimize things and handle that possibility we should probably suck in all the cbi raw into coreboot and operate on it locally instead of calling out to the EC for everything. Not for this patch, obviously.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If940a76d36a7645a7441ba418aa7aec9af9f6319
Gerrit-Change-Number: 39860
Gerrit-PatchSet: 3
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 27 Mar 2020 06:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment