Attention is currently required from: Hung-Te Lin, Jianjun Wang, Nico Huber, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78044?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek: PCI: Fix translation window
......................................................................
Patch Set 14:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/78044/comment/146a4d8e_c31b80ce :
PS14, Line 240: if (mtk_pcie_set_trans_window(&count, table_base, &conf->mmio_res_io)
: < 0) {
: printk(BIOS_ERR, "%s: Failed to set IO window, ignore it\n",
: __func__);
: count = 0;
: }
:
: /* Initialize memory resources constraints. */
: if (mtk_pcie_set_trans_window(&count, table_base, &conf->mmio_res_mem)
: < 0)
Nit: there is no need to break lines here. 96 chars is our (soft) limit.
Please fix it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78044?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42b0f0bf9222d284dee0c29f1a6ed6366d6e6689
Gerrit-Change-Number: 78044
Gerrit-PatchSet: 14
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Mon, 02 Oct 2023 06:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment