Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27094 )
Change subject: mainboard/google/nocturne: Set camera power sequence ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:
https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/... PS5, Line 37: Method (PMON, 0, Serialized) { : CTXS(FCAM_RST_L) : STXS(FCAM_PWR_EN) : STXS(PCH_FCAM_CLK_EN) : Sleep(3) : STXS(FCAM_RST_L) : } : : Method (PMOF, 0, Serialized) { : CTXS(PCH_FCAM_CLK_EN) : CTXS(FCAM_RST_L) : CTXS(FCAM_PWR_EN) : } Since these are used by both sensor and NVM, doesn't this need to be reference counted? Same for front camera.
https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/... PS5, Line 63: Return (0x0F) Shouldn't this return some actual status? Same for front camera.