Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 )
Change subject: soc/intel/apl: Add ACPI for SMBus control
......................................................................
Patch Set 9:
(1 comment)
Why can't the OS use its own SMBus driver? On Linux, i2c-i801
is responsible for 0x5ad4 (APL's SMBus PCI dev). Are we using/
reserving it in ASL? or do we maybe not expose the PCI device?
https://review.coreboot.org/c/coreboot/+/44507/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44507/9//COMMIT_MSG@10
PS9, Line 10: dump from AMI firmware
What license is this under? are you allowed to share it under the GPL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3846266d3155bbe831123fef4751748ff0e00511
Gerrit-Change-Number: 44507
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 27 Sep 2020 15:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment