Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33143 )
Change subject: Rampayload: Able to build coreboot without ramstage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33143/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/#/c/33143/3/Makefile.inc@1062 PS3, Line 1062: $(obj)/coreboot.rom: $(obj)/coreboot.pre $(CBFSTOOL) $$(INTERMEDIATE) Why not just introduce a variable that is empty if RAMPAYLOAD is 'y' and set to $(objcbfs)/ramstage.elf is not 'y'?
Then the line would be something like the following w/o duplicating other things:
$(obj)/coreboot.rom: $(obj)/coreboot.pre $(RAMSTAGE) $(CBFSTOOL) $$(INTERMEDIATE)
https://review.coreboot.org/#/c/33143/3/Makefile.inc@1136 PS3, Line 1136: cbfs-files-y += $(CONFIG_CBFS_PREFIX)/ramstage Technically, only this particular line needs to be guarded, fwiw. But you don't have to change it.