View Change
2 comments:
File Makefile.inc:
Patch Set #3, Line 1062: $(obj)/coreboot.rom: $(obj)/coreboot.pre $(CBFSTOOL) $$(INTERMEDIATE)
Why not just introduce a variable that is empty if RAMPAYLOAD is 'y' and set to $(objcbfs)/ramstage.elf is not 'y'?
Then the line would be something like the following w/o duplicating other things:
$(obj)/coreboot.rom: $(obj)/coreboot.pre $(RAMSTAGE) $(CBFSTOOL) $$(INTERMEDIATE)
Patch Set #3, Line 1136: cbfs-files-y += $(CONFIG_CBFS_PREFIX)/ramstage
Technically, only this particular line needs to be guarded, fwiw. But you don't have to change it.
To view, visit change 33143. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id000dfac2eb57a8eaaa505c89d798fb30b3706fe
Gerrit-Change-Number: 33143
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-Comment-Date: Fri, 31 May 2019 16:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment