Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40683 )
Change subject: soc/amd/picasso: Enable secure debug unlock conditionally
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40683/4/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40683/4/src/soc/amd/picasso/Kconfig...
PS4, Line 358: Select this item to enable secure debug options in PSP.
I prefer not, as it's NDA information. […]
Keeping it as is based on Marshall's comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47d8af67989b06242d662c77b7d9db97f624edd5
Gerrit-Change-Number: 40683
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Apr 2020 08:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment