Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Set default value for CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33116/7/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33116/7/src/Kconfig@252
PS7, Line 252: default n if !ENABLE_STAGE_RAMSTAGE
This is already default n implicitly, so what does this line add?
Also, this option doesn't appear in menuconfig and only seems to be designed to be 'select'ed by other options. 'select' always overrides everything else (both defaults and 'depends on'), so adding this here is pointless and potentially misleading, because it won't prevent the option from being on even if ENABLE_STAGE_RAMSTAGE is off.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Jun 2019 20:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment