[coreboot-gerrit] Change in coreboot[master]: [RFC] soc/intel/skylake: Introduce new method for setting device states

[Michael Niewöhner (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] soc/intel/skylake: Introduce new method for setting device states
......................................................................

Patch Set 13:

(4 comments)

File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/d14dace1_cb4ef3da 
PS13, Line 461: if (!xdci_can_enable())
              : 		params->XdciEnable = 0;
params->XdciEnable = xdci_can_enable();

File src/soc/intel/skylake/fspdevmap.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/de653e90_2798cf2e 
PS13, Line 15: devmap[i].inverted ^ dev->enabled
nit: I would exchange them, because we're inverting the dev state, not the invert field.

File src/soc/intel/skylake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/4b7a83db_2569a7a7 
PS13, Line 137: PCH_DEVFN_SMBUS },
              : 		{ &m_cfg->EnableTraceHub, PCH
alignment

https://review.coreboot.org/c/coreboot/+/52493/comment/03ea8207_f0d4c2cc 
PS13, Line 138:  
tab