Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39135 )
Change subject: src/soc/tigerlake: Add memory configuration support for Jasper Lake
......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39135/23/src/soc/intel/tigerlake/me...
File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39135/23/src/soc/intel/tigerlake/me...
PS23, Line 25: memcpy(&_mem_cfg->DqByteMapCh ## _ch, \
: &_b_cfg->dq_map[_ch], \
: sizeof(_b_cfg->dq_map[_ch])); \
: memcpy(&_mem_cfg->DqsMapCpu2DramCh ## _ch, \
: &_b_cfg->dqs_map[_ch], \
: sizeof(_b_cfg->dqs_map[_ch])); \
I really think this looks a lot better as just a little static function. […]
tried creating helper function bt looks like macro append won't work with static function. restoring the old method
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8de502d3f05d52b9dae34e3b013c6d5b1896fa85
Gerrit-Change-Number: 39135
Gerrit-PatchSet: 25
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 18:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment