Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46093 )
Change subject: soc/intel/xeon_sp: Move debug macros to console/debug.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46093/1/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/46093/1/src/soc/intel/xeon_sp/cpx/c... PS1, Line 4: : #include <console/debug.h>
My only complaint is that I would also keep console/console.h for any file that uses a printk(), i. […]
IMHO, I'd even go as far as to drop the <console/console.h> inclusion from <console/debug.h>. This prevents using any macro from there unless the necessary headers have been included. Since the compiler only sees macros if they are used in the code, including <console/debug.h> without including <console/console.h> would only work if none of the macros are used.
If this approach seems too cursed, notice that <console/debug.h> does not include any headers for the `dev_path` function.