Attention is currently required from: Keith Hui.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41735 )
Change subject: sb/intel/i82371eb: Implement SMBus Control Method Interface support
......................................................................
Patch Set 8:
(1 comment)
File src/southbridge/intel/i82371eb/acpi/smbus.asl:
https://review.coreboot.org/c/coreboot/+/41735/comment/3738cd01_8609b7e7
PS8, Line 25: Your board may need adjustment
By editing this device list. Updated comment to follow in next patch set.
Hmmm, if this is mainboard-specific, I'd rather have it defined in mainboard-specific code. One approach that doesn't increase coreboot.rom space usage would be to include a mainboard-provided header from here that defines _SBI
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97deb2d292af25e42068474f48e11c94a7480be6
Gerrit-Change-Number: 41735
Gerrit-PatchSet: 8
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Sat, 18 Dec 2021 12:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment