Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )
Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/...
PS3, Line 191: on
That is entirely dependent on the kernel that will be booted. […]
"bios should only allocated BAR for devices that it plan to use in bios space ..."
yes, that's why it need to be "on", as LTT programming is done in "bios space".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20fae04080b28c6105e5a187cc5d7a55b48d709
Gerrit-Change-Number: 33147
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 16:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment