Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32436 )
Change subject: mb/google/sarien: Disable POWER_OFF_ON_CR50_UPDATE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32436/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32436/2//COMMIT_MSG@11
PS2, Line 11: update when running on battery.
I'm a bit confused about this commit message. It states why it is […]
It was enabled globally before. This power architecture on this platform behaves differently than our previous x86 devices (with different behavior on battery and AC) and we need some special handling to ensure it powers up again after an EC reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32436
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b687285eb95070eaffb68611a7d98eb8434ce2c
Gerrit-Change-Number: 32436
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 25 Apr 2019 14:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment