Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33114 )
Change subject: Makefile.inc: Fix compilation issue with !CONFIG_ENABLE_STAGE_RAMSTAGE ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/#/c/33114/5/src/cpu/x86/Makefile.inc@20 PS5, Line 20: ifeq ($(CONFIG_STAGE_RAMSTAGE),y)
I'm getting below error when i'm skip guarding […]
Got it. Then that means someone is requesting sipi vector to be in the build. Taking a step back. Why would sipi not be needed for !RAMSTAGE? What is your solution to the larger problem?
Assuming this is the resulting intent (though, I disagree) I think you need to work out *why* these recipes are getting evaluated. ramstage-blah should never be acted upon because ramstage's root dependency should not be referenced. The fact that ramstage-srcs is being evaluated in some form is the root of the problem, I suspect. What if you just guard line 23? Does that work correctly?