Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31031 )
Change subject: cpu/intel/model_206ax: Remove the notion of sockets
......................................................................
Patch Set 8: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/31031/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31031/8//COMMIT_MSG@9
PS8, Line 9: With the memory controller
Should this say something like "With the memory controller as part of
the CPU package"?
https://review.coreboot.org/#/c/31031/8//COMMIT_MSG@12
PS8, Line 12: UNTESTED: This also updates autoport.
I tested it and autoport output looks fine.
https://review.coreboot.org/#/c/31031/8/src/mainboard/gigabyte/ga-b75m-d3h/d...
File src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb:
https://review.coreboot.org/#/c/31031/8/src/mainboard/gigabyte/ga-b75m-d3h/d...
PS8, Line 14: # Magic APIC ID to locate this chip
These comments are slightly out of place now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I044d434a5b8fca75db9eb193c7ffc60f3c78212b
Gerrit-Change-Number: 31031
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Jan 2019 07:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment