Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Felix Held, Maximilian Brune, Paul Menzel.
Marshall Dawson has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binary parsing ......................................................................
Patch Set 8:
(4 comments)
Patchset:
PS8: Since this gets used across SOC generations, I'd really like to see a sampling of successful tests with this patch. Will see if Felix can help.
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84373/comment/fc901a4d_f5568ef0?usp... : PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB }, : { .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB }, Dropping "Instance" seems like it could potentially be a problem.
https://review.coreboot.org/c/coreboot/+/84373/comment/fafb60f0_521aca35?usp... : PS8, Line 324: { .type = AMD_BIOS_APOB_NV, .level = BDT_BOTH }, Are you sure this is required? Or maybe it became a requirement on glinda? IIRC we've traditionally kept Level 1 as minimal as possible.
https://review.coreboot.org/c/coreboot/+/84373/comment/9e245410_398e269c?usp... : PS8, Line 381: { .type = AMD_BIOS_MP2_CFG, .level = BDT_BOTH }, Same as above.