20 Sep
2019
20 Sep
'19
10:52 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35463/5/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/5/src/include/device/mmio.h@1... PS5, Line 137: #define GET_BITFIELD(value, name) \
I thought about write, but it's really more like "setting some of the fields" and close to clrsetbi […]
Done with WRITE32_FIELDS and READ32_FIELD.
And to get multiple fields from one reg3, do read32 then EXTRACT_BITFIELD multiple times.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 08:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment