Attention is currently required from: Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/69543/comment/f759c6f0_913f6f99 PS1, Line 38: unsigned int bus_speed; /* Bus clock in Hz (default 400 kHz) */ I'm in doubt here whether this default is the "datasheet default" or the default in rv3028c7.c, which is 100 kHz. The same situation as in the RX6110 RTC driver. Seems confusing.