Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )
Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39690/4/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/39690/4/src/mainboard/ocp/tiogapass...
PS4, Line 33: init_frb2_wdt
The starting and stopping IPMI watchdog part is the standard IPMI BMC watchdog, which should be boar […]
oh I see. It feels then we would end up duplicating this functionality on every OCP mainboard. Shall we just move this common mb code in vendorcode? David, whats is your take on this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53b69c3c5d22c022130fd812ef26097898d913d0
Gerrit-Change-Number: 39690
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 20:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment
