Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33962 )
Change subject: arch/x86: Use ssize_t to store length
......................................................................
Patch Set 1:
Patch Set 1:
can't see an error [-Werror=sign-compare] on 'acpi_device.c' here : https://qa.coreboot.org/job/coreboot-gerrit/97548/consoleFull
I think -Wtype-limits is more in line with what you're looking for, but that doesn't catch it since <= 0 is still valid for unsigned types. -Wconversion would catch it though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8ed62ecfac8eaa18a61545bd203b3c7a7cd9ca5
Gerrit-Change-Number: 33962
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 19:55:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment