Attention is currently required from: Hsuan-ting Chen, Subrata Banik, Tarun Tuli.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75330?usp=email )
Change subject: lib: Support localized text of memory_training_desc in ux_locales.c
......................................................................
Patch Set 8:
(1 comment)
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75330/comment/d38da3e7_1ae5f5d5 :
PS5, Line 408: romstage-y += ux_locales.c
It might be better to have another feature enablement config, namely MAINBOARD_USE_EARLY_LIBGFXINIT, which depends on MAINBOARD_HAS_EARLY_LIBGFXINIT. This could be set to the default n and enabled in the coreboot ebuild.
Yes, but please don't call it "MAINBOARD_USE_...". We use the "MAINBOARD_..." prefix to specifically mark Kconfigs that indicate hardware support. For the user decision Kconfig you can just call it CONFIG_EARLY_UX or something like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75330?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e3c8d103c938a11b397c32c9228e44e31c3f01d
Gerrit-Change-Number: 75330
Gerrit-PatchSet: 8
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 19:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment