Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43241 )
Change subject: mb/hp/abm: Drop dead code ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43241/2/src/mainboard/hp/abm/acpi/i... File src/mainboard/hp/abm/acpi/ide.asl:
https://review.coreboot.org/c/coreboot/+/43241/2/src/mainboard/hp/abm/acpi/i... PS2, Line 4:
drop the whole file
IIRC it causes build problems because it is unconditionally included.
https://review.coreboot.org/c/coreboot/+/43241/2/src/mainboard/hp/abm/acpi/s... File src/mainboard/hp/abm/acpi/sata.asl:
https://review.coreboot.org/c/coreboot/+/43241/2/src/mainboard/hp/abm/acpi/s... PS2, Line 2:
drop the whole file
IIRC it causes build problems because it is unconditionally included.