Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: soc/baytrail: Add native refcode replacement ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 50: table->reg); Does this fit into 96 characters?
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 116: int Please use `size_t` or `unsigned int`.
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 118: printk(BIOS_DEBUG, "ModPHY init entry\n"); It’d be great if you also added timestamps for running the ref code.
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 126: "SOC B0 and later ModPhy Table programming\n"); Does this fit into 96 characters?
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 135: "Polling bit3 of R_PCH_PMC_MTPMC1 = %x\n", tmp); Does this fit into 96 characters?