Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49093 )
Change subject: cpu/intel/model_206ax: Replace `generate_cstate_entries`
......................................................................
Patch Set 2:
(2 comments)
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/49093/comment/968b1205_7d875269
PS2, Line 54: acpi_cstates
possible buffer overflow.
https://review.coreboot.org/c/coreboot/+/49093/comment/e6d26aa2_55660df9
PS2, Line 55: i + 1
shouldn't the ctype be already correct here? why do you need to update it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icec5431987d91242930efcea0c8ea4e3df3182fd
Gerrit-Change-Number: 49093
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 18 Jan 2021 07:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment