Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37283 )
Change subject: soc/intel/common/block/cse: Modify handling of HMRFPO_ENABLE command ......................................................................
Patch Set 4:
(10 comments)
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@9 PS4, Line 9: Below changes have been done in send_hmrfpo_enable_msg(): Maybe:
Change send_hmrfpo_enable_msg() as below:
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@11 PS4, Line 11: operation mode is Temp Disable Mode. Please remove the dot/period at the end, or at one to the third item.
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@12 PS4, Line 12: 2. Add check for response status. Check response status
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@13 PS4, Line 13: 3. Add description for the send_hmrfpo_enable_msg() Describe/document send_hmrfpo_enable_msg()
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@17 PS4, Line 17: EOP What is that?
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@20 PS4, Line 20: 1. Ensure CSE to boot from BP1. When CSE boots from BP1, it will have
Ensure CSE boots from BP1. …
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@21 PS4, Line 21: opmode- Remove -.
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@22 PS4, Line 22: 2. Send HMRFPO_ENABLE command to CSE. Remove line break.
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@26 PS4, Line 26: allow allows
https://review.coreboot.org/c/coreboot/+/37283/4//COMMIT_MSG@39 PS4, Line 39: TEST=Verfied on hatch board. How did you verify this?