Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38010 )
Change subject: nb/intel/sandybridge: add and use more MCHBAR register defines ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
Patch Set 1: Code-Review+2
(3 comments)
I'll add the missing registers myself, this patch is rather buried in the train
I'll add those in a follow-up patch; those don't need to be in this patch and I'm not too motivated to edit a patch in the middle of this patch train
That's what I meant. I'm taking care of it already.
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 157: 0x5e04
MC_BIOS_DATA […]
CB:38029
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 135: PM_PDWN_Config
This should be all uppercase (maybe on another patchset): PM_PDWN_CONFIG
CB:38028