Attention is currently required from: Nicholas Chin, Riku Viitanen.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email )
Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74906/comment/88de1b06_54f0fdd1 : PS1, Line 9: register "gen2_dec" = "0x00fc0801"
SuperIO (and other) logs can be downloaded here: https://viitanen.xyz/8300usdt_autoport_logs.tar.gz […]
ioports.log had this:
0680-069f : pnp 00:01 0a10-0a1f : pnp 00:04 0a20-0a3f : pnp 00:04
superiotool.log had this:
LDN 0x04 (SWC) idx val def 0x30: 0x01 (0x00) 0x60: 0x0a (0x08) 0x61: 0x00 (0xe6) 0x62: 0x0a (0x08) 0x63: 0x10 (0xe0)
Seems to me like some of the superio LDN entries below did not originate from autoport tool, but also the LDN IO device base addresses between ioports.log and superiotool are not consistent.
Since it's a single board port and not in common code, I feel like this could be submitted commit message is adjusted to note some super-io LDN devices may be incorrectly configured.
https://review.coreboot.org/c/coreboot/+/74906/comment/9c243ccd_239a3f35 : PS1, Line 80: io 0x60 = 0x600
How would I go about adding that? I'm a complete n00b.
It would be a gen3_dec entry above. But if you do not need to access registers inside this LDN early in the boot, it may get automatically configured.