Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38016 )
Change subject: Documentation/superio: add generic PNP device documentation ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38016/3/Documentation/superio/commo... File Documentation/superio/common/pnp.md:
https://review.coreboot.org/c/coreboot/+/38016/3/Documentation/superio/commo... PS3, Line 38: of of of
https://review.coreboot.org/c/coreboot/+/38016/3/Documentation/superio/commo... PS3, Line 46: There redundant with "here" later in the sentence.
https://review.coreboot.org/c/coreboot/+/38016/3/Documentation/superio/commo... PS3, Line 55: The first register selects the IRQ number from 1 to 15 and 0 deactivated the corresponding IRQ. That took me three attempts until I understood what you mean. Maybe something like: "Each pair can be configured to use a certain interrupt ID. Writing 1 to 15 into the first register enables using that IRQ# while 0 disables it."?