Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34773 )
Change subject: soc/mediatek: dsi: Support sending MIPI init commands
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34773/10/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34773/10/src/soc/mediatek/common/ds...
PS10, Line 307: mtk_dsi_start();
Already called inside mtk_dsi_init(), is this intended?
Yes this is intended. Without that DSI won't fetch the cmdq.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c824873465ac82a95bcb0ed67b8b9866987008
Gerrit-Change-Number: 34773
Gerrit-PatchSet: 11
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Comment-Date: Thu, 08 Aug 2019 07:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment