Attention is currently required from: Furquan Shaikh, Martin Roth, Selma Bensaid, Subrata Banik, Usha P, Andrey Petrov, Patrick Rudolph.
Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51105 )
Change subject: intel/common/block/memory: Add saving memory info API
......................................................................
Patch Set 6:
(3 comments)
File src/drivers/intel/fsp2_0/hob_memory_info.c:
PS2:
Done
Resolved
https://review.coreboot.org/c/coreboot/+/51105/comment/af0933c9_7de9b096
PS2, Line 16: #ifndef CHANNEL_NOT_PRESENT
: #define CHANNEL_NOT_PRESENT 0 // There is no channel present on the controller.
: #endif
: #ifndef CHANNEL_DISABLED
: #define CHANNEL_DISABLED 1 // There is a channel present but it is disabled.
: #endif
: #ifndef CHANNEL_PRESENT
: #define CHANNEL_PRESENT 2 // There is a channel present and it is enabled.
: #endif
Done
Resolved
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/51105/comment/181f437f_5b9004bd
PS1, Line 40: #define FSP_SMBIOS_MEMORY_INFO_GUID \
: { \
: 0xd4, 0x71, 0x20, 0x9b, 0x54, 0xb0, 0x0c, 0x4e, \
: 0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
: }
Done
Resolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d14c71d5d19f58e6a27ed5ef8269c6678f32a5
Gerrit-Change-Number: 51105
Gerrit-PatchSet: 6
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 10 Mar 2021 17:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-MessageType: comment