Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39969 )
Change subject: nb/intel/sandybridge: Read spds only once if measured boot is enabled ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@7 PS2, Line 7: spds SPDs
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@9 PS2, Line 9: spd SPD
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@10 PS2, Line 10: spd SPD
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@10 PS2, Line 10: condition conditions
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@13 PS2, Line 13: spd SPD
https://review.coreboot.org/c/coreboot/+/39969/2//COMMIT_MSG@13 PS2, Line 13: CB:39906 Do you mean the commit or review comments? Please add the URL for people using `git log`.
https://review.coreboot.org/c/coreboot/+/39969/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/39969/2/src/northbridge/intel/sandy... PS2, Line 103: spd SPD
https://review.coreboot.org/c/coreboot/+/39969/2/src/northbridge/intel/sandy... PS2, Line 103: an a
https://review.coreboot.org/c/coreboot/+/39969/2/src/northbridge/intel/sandy... PS2, Line 107: sum += spds[i][j]; Can’t you just return, if one element is greater 0, that means the first time you find that element?