Attention is currently required from: Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 29:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/3e5a3187_f8d05975 PS29, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/533d1974_dec66af8 PS29, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/f4713100_d9ba9920 PS29, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/f539da05_d0b25d24 PS29, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/2ca13295_72651b24 PS29, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/8fca48f2_da1584b8 PS29, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/922ed3f0_d848d7e6 PS29, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/0a6dbfd0_3d975ea1 PS29, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/d8b32180_98c853ab PS29, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/0b90a5e1_a5a650b8 PS29, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/d3c24ce6_c7fb5691 PS29, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/da384dd5_0b7ef50c PS29, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/7406a81e_13d30734 PS29, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/f3d59d66_d8a97d33 PS29, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/f5365e04_37d29ff9 PS29, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/6009b098_ef0c91fe PS29, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/508950e7_e316be2e PS29, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/cd0d74b5_7578e26f PS29, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/fa857cf7_b134c6db PS29, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/28bbbd0b_c91a7c8e PS29, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/acc7d4f8_4544a9f2 PS29, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/94608aa0_946e24a6 PS29, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/15729dea_bac437ec PS29, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/8bbd549e_f4bf8d2c PS29, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/a671974e_0c692a11 PS29, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/0e4d5c40_b56aee37 PS29, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/5f36aff8_4361f8d0 PS29, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/79f99134_31076715 PS29, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/1cce1111_0aa0f9ed PS29, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/d6b6fdf8_43a38376 PS29, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/24669024_1449bae2 PS29, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/a842d9b7_7235d0fc PS29, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/6d6494ff_ee30797c PS29, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/115ffb6d_b3eea48a PS29, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/dd2fd144_811d9c16 PS29, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/60575971_2d510d2b PS29, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/e402035e_3c15b299 PS29, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/53df18f2_11e97d4a PS29, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/b058cf66_a279fac3 PS29, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/efd728c0_95a49464 PS29, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/5162f616_37216f1c PS29, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117208): https://review.coreboot.org/c/coreboot/+/49768/comment/ef080118_2f3cc9ad PS29, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line