Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36794 )
Change subject: mb/intel/coffeelake_rvp: Switch to overridetree setup ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patch Set 5:
Anything needs to do with this patch?
I think it's good enough. Do note that all comments on a change need to be resolved to be able to merge it.
If possible, it would be good to confirm that the boards still boot fine with this change. Better safe than sorry :D
https://review.coreboot.org/c/coreboot/+/36794/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36794/4//COMMIT_MSG@7 PS4, Line 7: override
oops, overridetree
Done
https://review.coreboot.org/c/coreboot/+/36794/4/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36794/4/src/mainboard/intel/coffeel... PS4, Line 72: device domain 0 on
sounds good
Done