build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31787 )
Change subject: soc/intel/cannonlake: Move power_state functions to pmutil.c ......................................................................
Patch Set 1:
(68 comments)
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c File src/soc/intel/cannonlake/pmutil.c:
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 204: uint32_t deep_s3_pol; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 204: uint32_t deep_s3_pol; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 206: deep_s3_pol = read32(pmc_mmio_regs() + S3_PWRGATE_POL); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 206: deep_s3_pol = read32(pmc_mmio_regs() + S3_PWRGATE_POL); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 207: return !!(deep_s3_pol & (S3DC_GATE_SUS | S3AC_GATE_SUS)); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20... PS1, Line 207: return !!(deep_s3_pol & (S3DC_GATE_SUS | S3AC_GATE_SUS)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 212: int prev_sleep_state) code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 212: int prev_sleep_state) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 215: /* code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 216: * Check for any power failure to determine if this a wake from code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 217: * S5 because the PCH does not set the WAK_STS bit when waking code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 218: * from a true G3 state. code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@21... PS1, Line 219: */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 220: if (ps->gen_pmcon_b & (PWR_FLR | SUS_PWR_FLR)) code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 220: if (ps->gen_pmcon_b & (PWR_FLR | SUS_PWR_FLR)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 221: prev_sleep_state = ACPI_S5; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 221: prev_sleep_state = ACPI_S5; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 223: /* code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 224: * If waking from S3 determine if deep S3 is enabled. If not, code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 225: * need to check both deep sleep well and normal suspend well. code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 226: * Otherwise just check deep sleep well. code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 227: */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 228: if (prev_sleep_state == ACPI_S3) { code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 228: if (prev_sleep_state == ACPI_S3) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@22... PS1, Line 229: /* PWR_FLR represents deep sleep power well loss. */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 230: uint32_t mask = PWR_FLR; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 230: uint32_t mask = PWR_FLR; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 232: /* If deep s3 isn't enabled check the suspend well too. */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 233: if (!deep_s3_enabled()) code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 233: if (!deep_s3_enabled()) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 234: mask |= SUS_PWR_FLR; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 234: mask |= SUS_PWR_FLR; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 236: if (ps->gen_pmcon_b & mask) code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 236: if (ps->gen_pmcon_b & mask) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 237: prev_sleep_state = ACPI_S5; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 237: prev_sleep_state = ACPI_S5; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 238: } code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@23... PS1, Line 238: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 240: return prev_sleep_state; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 240: return prev_sleep_state; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 245: uint8_t *pmc; code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 245: uint8_t *pmc; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 247: ps->tco1_sts = tco_read_reg(TCO1_STS); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 247: ps->tco1_sts = tco_read_reg(TCO1_STS); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 248: ps->tco2_sts = tco_read_reg(TCO2_STS); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@24... PS1, Line 248: ps->tco2_sts = tco_read_reg(TCO2_STS); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 250: printk(BIOS_DEBUG, "TCO_STS: %04x %04x\n", code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 250: printk(BIOS_DEBUG, "TCO_STS: %04x %04x\n", please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 251: ps->tco1_sts, ps->tco2_sts); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 251: ps->tco1_sts, ps->tco2_sts); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 253: pmc = pmc_mmio_regs(); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 253: pmc = pmc_mmio_regs(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 254: ps->gen_pmcon_a = read32(pmc + GEN_PMCON_A); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 254: ps->gen_pmcon_a = read32(pmc + GEN_PMCON_A); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 255: ps->gen_pmcon_b = read32(pmc + GEN_PMCON_B); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 255: ps->gen_pmcon_b = read32(pmc + GEN_PMCON_B); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 256: ps->gblrst_cause[0] = read32(pmc + GBLRST_CAUSE0); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 256: ps->gblrst_cause[0] = read32(pmc + GBLRST_CAUSE0); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 257: ps->gblrst_cause[1] = read32(pmc + GBLRST_CAUSE1); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 257: ps->gblrst_cause[1] = read32(pmc + GBLRST_CAUSE1); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 259: printk(BIOS_DEBUG, "GEN_PMCON: %08x %08x\n", code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@25... PS1, Line 259: printk(BIOS_DEBUG, "GEN_PMCON: %08x %08x\n", please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 260: ps->gen_pmcon_a, ps->gen_pmcon_b); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 260: ps->gen_pmcon_a, ps->gen_pmcon_b); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 262: printk(BIOS_DEBUG, "GBLRST_CAUSE: %08x %08x\n", code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 262: printk(BIOS_DEBUG, "GBLRST_CAUSE: %08x %08x\n", please, no spaces at the start of a line
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 263: ps->gblrst_cause[0], ps->gblrst_cause[1]); code indent should use tabs where possible
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@26... PS1, Line 263: ps->gblrst_cause[0], ps->gblrst_cause[1]); please, no spaces at the start of a line