Attention is currently required from: Julius Werner, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77193?usp=email )
Change subject: libpayload/cbfs: Fill size_out even if cbfs_map() fails
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
I don't mind the change but I'm a bit reluctant to say that it's okay to look at size_out when the o […]
Yeah, I know. I've updated the commit message, and also uploaded CL:4781958 to fix the caller.
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/77193/comment/7fd77e39_f3c6a721 :
PS1, Line 169: }
I think you're not setting it in this path now.
Oops. Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77193?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82c6b7e69c95bf597fa3c7d37dd11252893c01af
Gerrit-Change-Number: 77193
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Wed, 16 Aug 2023 03:32:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment