Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: Make MP init timeout configurable ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c@523 PS1, Line 523: * increases (contention for resources like UART also increases). Comment needs update.
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c@525 PS1, Line 525: const int timeout_us = CONFIG_FLIGHT_PLAN_TIMEOUT_US; Why not simply increase the timeout for all targets instead of adding a Kconfig. We should never expect an AP to stall, should we?