Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38691 )
Change subject: soc/amd/picasso: Enable cache in bootblock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38691/2/src/soc/amd/picasso/bootblo...
File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38691/2/src/soc/amd/picasso/bootblo...
PS2, Line 75: MTRR_TYPE_WRBACK);
code indent should use tabs where possible
wasn't it always indent with tabs and align with spaces? or should i just indent the second half with one more tab than the first half?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38691
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5615ff60ca196e622a939b46276a4a0940076ebe
Gerrit-Change-Number: 38691
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 19:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment