Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37649 )
Change subject: mb/google/octopus/variants/bobba: fix LTE power sequence
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37649/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37649/1//COMMIT_MSG@10
PS1, Line 10:
Can get_board_sku() be put into a separate file - eg. board_info.c or mainboard_misc.c. […]
if use google_chromeec_cbi_get_sku_id() is much simple to replaced get_board_sku() rather then create a new file to let it added in smm mode?
I will describe detail in commit, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I287ba1cb092a95b3a9dd1f960a3b84fd85b9b221
Gerrit-Change-Number: 37649
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 13 Dec 2019 09:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment