Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33799 )
Change subject: src/lib/hexdump: Use size_t for length
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c
File src/lib/hexdump.c:
https://review.coreboot.org/c/coreboot/+/33799/6/src/lib/hexdump.c@67
PS6, Line 67: int
I'd use size_t here as well
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29a7ae8c499bb1e8ab7c8741b2dfb7663d82a362
Gerrit-Change-Number: 33799
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 12:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment