Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36654/2/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/2/payloads/libpayload/drivers...
PS2, Line 241: switch (ch) {
: case 0xb:
: ret = KEY_F(12);
: break;
: case 0x5e:
: ret = POWER_BUTTON;
: break;
: case 0x4b:
: ret = KEY_LEFT;
: break;
: case 0x4d:
: ret = KEY_RIGHT;
: break;
: case 0x48:
: ret = KEY_UP;
: break;
: case 0x50:
: ret = KEY_DOWN;
: break;
: default:
: ret = 0;
: }
We don't want to hard code this list for everyone it will be different on each platform. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c11939d18391bebe53ca21cf33a096ba369cd56
Gerrit-Change-Number: 36654
Gerrit-PatchSet: 2
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Nov 2019 22:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment