Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36416 )
Change subject: Makefile, Kconfig: Add AMD dependency for amd_blobs repo
......................................................................
Patch Set 1:
Patch Set 1:
Thanks for handling the license issue with so much care.
I wonder, though, is there a reason not to integrate it as
a submodule? We already have other blob repos guarded
by a Kconfig. Could we handle the AMD repo in a similar
way?
I agree, a submodule with update=none would fit in with the other git repos we import.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ae807659db16756453dc3db2c51848291c681b8
Gerrit-Change-Number: 36416
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 29 Oct 2019 14:05:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment