Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86868?usp=email )
Change subject: Makefile: Add build/3rdparty as an exception for project_filelist.txt ......................................................................
Makefile: Add build/3rdparty as an exception for project_filelist.txt
The ctags tool (called by ctags-project target) currently complains about not finding certain files: ``` ctags: Warning: cannot open input file "bl31/aarch64/bl31_entrypoint.S" : No such file or directory ctags: Warning: cannot open input file "bl31/aarch64/crash_reporting.S" : No such file or directory ctags: Warning: cannot open input file "bl31/aarch64/runtime_exceptions.S" : No such file or directory ctags: Warning: cannot open input file "bl31/bl31.ld.S" : No such file or directory ctags: Warning: cannot open input file "bl31/bl31_context_mgmt.c" : No such file or directory ctags: Warning: cannot open input file "bl31/bl31_main.c" : No such file or directory ctags: Warning: cannot open input file "bl31/bl31_traps.c" : No such file or directory ctags: Warning: cannot open input file "bl31/interrupt_mgmt.c" : No such file or directory ctags: Warning: cannot open input file "common/aarch64/debug.S" : No such file or directory ctags: Warning: cannot open input file "common/bl_common.c" : No such file or directory ctags: Warning: cannot open input file "common/fdt_fixup.c" : No such file or directory ... ```
The project_filelist.txt generation includes the compiler generated "*.d" files, except for files found in build/util. Most file paths in these "*.d" files are file paths relative to the root directory of coreboot. Some projects though are compiled separately from coreboot (e.g. payload, vboot, util). Some of these (e.g. util, vboot) are also put into the build directory of coreboot and relative file paths are relative to these projects instead of coreboot. This has the uncanning side effect that the ctags Makefile target can't find these files, since they are not relative to the coreboot root directory.
This patch excludes the build/3rdparty directory from those files, since they contain 'separately' compiled projects like 3rdparty/arm-trusted-firmware.
Signed-off-by: Maximilian Brune maximilian.brune@9elements.com Change-Id: I18d0377e327530d9ef9382c324a305d156c5c681 Reviewed-on: https://review.coreboot.org/c/coreboot/+/86868 Reviewed-by: Paul Menzel paulepanter@mailbox.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/Makefile b/Makefile index 49c19cb..24b7c96 100644 --- a/Makefile +++ b/Makefile @@ -473,7 +473,7 @@ echo "*** Error: Project must be built before generating file list ***"; \ exit 1; \ fi - find $(obj) -path "$(obj)/util" -prune -o -path "$(obj)/external" -prune -o -name "*.d" -exec cat {} ; | \ + find $(obj) -path "$(obj)/util" -prune -o -path "$(obj)/external" -prune -o -path "$(obj)/3rdparty" -prune -o -name "*.d" -exec cat {} ; | \ sed "s|$(top)/||" | sed 's/[:\]/ /g' | sed 's/ /\n/g' | sort | uniq | \ grep -v '.o$$' > $(obj)/project_filelist.txt