Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Nick Vaccaro, Tarun, Tim Crawford.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79631?usp=email )
Change subject: soc/intel: Add config to use S3 over S0ix
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79631/comment/8d01d5cc_194cddd3 :
PS2, Line 11: indicating to the OS that S3
: suspend is the preferred sleep method.
Is this accurate? I think the bit indicates the S0ix capability. If you don't set it the OS cannot suspend that way. If so this would just disable s0ix?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79631?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife98166338c5457fb2c7dad81a30e54f487495f6
Gerrit-Change-Number: 79631
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 06 Jan 2024 11:30:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment