[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Add SMBus support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31661 )

Change subject: soc/intel/braswell: Add SMBus support
......................................................................

Patch Set 1:

(3 comments)

Can you please paste the build error in a comment here?

https://review.coreboot.org/#/c/31661/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31661/1//COMMIT_MSG@9 
PS1, Line 9: not
no

https://review.coreboot.org/#/c/31661/1//COMMIT_MSG@17 
PS1, Line 17: include
included

https://review.coreboot.org/#/c/31661/1//COMMIT_MSG@9 
PS1, Line 9: Intel Braswell SoC contains SMBus controller but not support
           : is available for this controller.
           : This controller is compatible with the Intel SMBus support in the
           : southbridge directory. This smbus.c file in that directory
           : is included.
           : This smbus.c file can be included in build using config
           : SOUTHBRIDGE_INTEL_COMMON and
           : SOUTHBRIDGE_INTEL_COMMON_SMBUS also. This results
           : into build errors, caused by pmbase.c and rtc.c which is include
           : always..
Please add blank lines between paragraphs.