Can you please paste the build error in a comment here?
View Change
3 comments:
Commit Message:
Patch Set #1, Line 9: not
no
Patch Set #1, Line 17: include
included
Patch Set #1, Line 9:
Intel Braswell SoC contains SMBus controller but not support
is available for this controller.
This controller is compatible with the Intel SMBus support in the
southbridge directory. This smbus.c file in that directory
is included.
This smbus.c file can be included in build using config
SOUTHBRIDGE_INTEL_COMMON and
SOUTHBRIDGE_INTEL_COMMON_SMBUS also. This results
into build errors, caused by pmbase.c and rtc.c which is include
always..
Please add blank lines between paragraphs.
To view, visit change 31661. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d4f657558a1aed21b083ef5cad08ea96e629c3
Gerrit-Change-Number: 31661
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 28 Feb 2019 16:34:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment