Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62820 )
Change subject: soc/intel/common/block/cse: Change loglevel prefix to WARNING ......................................................................
soc/intel/common/block/cse: Change loglevel prefix to WARNING
This message is not really an error message, so BIOS_ERR is inappropriate. The message does seem more like a warning though, that the developer could have multiple Kconfigs selected to send EOP, therefore switch to BIOS_WARN instead.
BRANCH=firmware-brya-14505.B TEST=build
Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Change-Id: I57a34334007a6a7443302c2f25de3d5c87c85573 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62820 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse_eop.c b/src/soc/intel/common/block/cse/cse_eop.c index a8c8bbd..b8b8e36 100644 --- a/src/soc/intel/common/block/cse/cse_eop.c +++ b/src/soc/intel/common/block/cse/cse_eop.c @@ -204,7 +204,7 @@ static bool eop_sent = false;
if (eop_sent) { - printk(BIOS_ERR, "EOP already sent\n"); + printk(BIOS_WARNING, "EOP already sent\n"); return; }
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.