[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Identify between ICH and PCH Revision

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44816 )

Change subject: util/ifdtool: Identify between ICH and PCH Revision
......................................................................

util/ifdtool: Identify between ICH and PCH Revision

Consider IBEX_PEAK onwards all chipsets are belong to PCH
family.

BUG=b:153888802
TEST=Able to print correct PCH revision on Hatch Platform.
> ifdtool -d coreboot.rom

Without this CL :
ICH Revision: 300 series Cannon Point/ 400 series Ice Point

With this CL :
PCH Revision: 300 series Cannon Point/ 400 series Ice Point

Signed-off-by: Subrata Banik 
Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4
---
M util/ifdtool/ifdtool.c
1 file changed, 11 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44816/1

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 1880900..b15b163 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -511,6 +511,13 @@
    }
 }

+static int is_platform_with_pch(void)
+{
+	if (chipset >= CHIPSET_5_SERIES_IBEX_PEAK)
+		return 1;
+
+	return 0;
+}
 static void dump_fcba(const fcba_t *fcba)
 {
    printf("\nFound Component Section\n");
@@ -757,7 +764,10 @@
    if (!fdb)
    	exit(EXIT_FAILURE);

-	printf("ICH Revision: %s\n", ich_chipset_names[chipset]);
+	if (is_platform_with_pch())
+		printf("PCH Revision: %s\n", ich_chipset_names[chipset]);
+	else
+		printf("ICH Revision: %s\n", ich_chipset_names[chipset]);
    printf("FLMAP0:    0x%08x\n", fdb->flmap0);
    printf("  NR:      %d\n", (fdb->flmap0 >> 24) & 7);
    printf("  FRBA:    0x%x\n", ((fdb->flmap0 >> 16) & 0xff) << 4);