Attention is currently required from: Fabian Groffen, Keith Hui.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email )
Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75137/comment/5633a2cf_5e3e8f89 :
PS4, Line 30: drq 0x1a = 0x02
Can you test with these two settings (0x1a,0x1b) retained if serial port still work?
I did this test. Serial port still works both ways. These two lines should also stay.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75137?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c
Gerrit-Change-Number: 75137
Gerrit-PatchSet: 4
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Fabian Groffen
grobian@gentoo.org
Gerrit-Comment-Date: Sat, 30 Sep 2023 14:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment